generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unzip files after retrieving from external SFTP site #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initialize correctly Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: Samuel Aquino <saquino@flexion.us> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: jherrflexion <118225331+jherrflexion@users.noreply.github.com>
…ad unzipped files to import; use constants for repeated strings; a lil cleanup and refactoring Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: Samuel Aquino <saquino@flexion.us> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: jherrflexion <118225331+jherrflexion@users.noreply.github.com>
…it can be reused Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: Samuel Aquino <saquino@flexion.us> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: jherrflexion <118225331+jherrflexion@users.noreply.github.com>
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com>
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com>
…sed on file type; update tests Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: jherrflexion <118225331+jherrflexion@users.noreply.github.com>
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: jherrflexion <118225331+jherrflexion@users.noreply.github.com>
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: jherrflexion <118225331+jherrflexion@users.noreply.github.com>
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: jherrflexion <118225331+jherrflexion@users.noreply.github.com>
Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
pluckyswan
approved these changes
Jul 3, 2024
jcrichlake
approved these changes
Jul 5, 2024
saquino0827
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A ton of refactor work in here and it looks great! Nice job all.
… some log statements Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com>
Co-Authored-By: jcrichlake <145698165+jcrichlake@users.noreply.github.com> Co-Authored-By: pluckyswan <96704946+pluckyswan@users.noreply.github.com> Co-Authored-By: Samuel Aquino <saquino@flexion.us> Co-Authored-By: Tiffini Johnson <86614374+tjohnson7021@users.noreply.github.com>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unzip files after retrieving from external SFTP site
After retrieving a file from an external SFTP site, we check if it is a zip file. If no, place file into
import
, if yes, unzip the file. Place resulting individual files intoimport
for processing, unlocking them with a password if appropriate. If there are errors reading any individual files within the zip, we add that info to a document and upload it tofailures
We also updated test naming to use a single consistent pattern
Issue
CDCgov/trusted-intermediary#1079
Checklist
Note: You may remove items that are not applicable